code review 5640045: doc: expand code.html to discuss the go tool in more depth (issue 5640045)

[adg-iFWiy5xATs8dnm+]

Hello golang-dev-/***@public.gmane.org, balasanjay-***@public.gmane.org (cc:
golang-dev-/***@public.gmane.org),

Please take another look.


http://codereview.appspot.com/5640045/

[r***@golang.org]

comments on the first half


http://codereview.appspot.com/5640045/diff/7001/doc/code.html
File doc/code.html (right):

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode10
doc/code.html:10: installing, and fetching Go packages and commands.
don't you fetch before you build and install?

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode22
doc/code.html:22: the <code>GOPATH</code> environment variable.
this paragraph is correct but stilted. try a rewrite. say it out loud.

also you need to say what GOPATH is: what it means and its syntax. it's
introduced badly.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode26
doc/code.html:26: A <code>GOPATH</code> entry contains Go source files,
package objects, and
what is a GOPATH entry? i thought it would just be the name of a
directory.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode31
doc/code.html:31: <li>Source files are kept under
<code>$GOPATH/src/<i>importpath</i></code>
what is an importpath?

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode41
doc/code.html:41: in a directory are considered part of the one package.
subdirectories form independent packages

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode86
doc/code.html:86: $ mkdir -p $GOPATH/src/example
set GOPATH

http://codereview.appspot.com/5640045/

[r***@golang.org]

comments on the rest


http://codereview.appspot.com/5640045/diff/7001/doc/code.html
File doc/code.html (right):

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode146
doc/code.html:146: This package is imported by its path name, starting
after the <code>src</code>
the path name of the directory it's in

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode158
doc/code.html:158: The <code>go</code> tool takes several commands, the
most central being
s/takes/comprises/

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode165
doc/code.html:165: to the <code>pkg</code> or <code>bin</code>
subdirectories of the
s/subdirectories/subdirectory/

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode166
doc/code.html:166: <code>GOPATH</code> in which the package source
resides.
another meaning of GOPATH

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode176
doc/code.html:176: $ go install example/newmath
if you're in example/newmath, which you usually are when you're working
on it, you only need
go install

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode180
doc/code.html:180: No output means that the package and all its
dependencies were built correctly.
"No output" is a confusing subject for a sentence, and grammatically
ambigous.

No people mean to do that.
No people means to do that.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode232
doc/code.html:232: Then we run <code>go install</code>, which builds and
installs the binary to
s/Then/Next,/ ?

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode241
doc/code.html:241: To run the program, invoke it by name like you would
any other command:
the subject of these sentences is sliding around: passive voice, you,
it, we, ...

decide who the subject is and stick with it

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode255
doc/code.html:255: The <code>GOPATH</code> tree now looks like this:
what's a GOPATH tree?

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode271
doc/code.html:271: When building a command the executable is written the
current directory.
tell them what it's called. it's not obvious.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode280
doc/code.html:280: Go has a lightweight test framework composed of the
<code>go</code> tool and
really the go test subcommand

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode294
doc/code.html:294: Let's add a test to our <code>newmath</code> package
by creating the file
shifting subjects again

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode331
doc/code.html:331: revision control system (such as Git or Mercurial).
This allows the
drop the parens

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode332
doc/code.html:332: <code>go</code> tool to automatically fetch packages
from remote repositories.
unsplit the infinitive

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode352
doc/code.html:352: like this:
if it's already present but in a later directory, does it replace or
override?

http://codereview.appspot.com/5640045/

[b***@public.gmane.org]

Didn't read it in depth, just skimmed it.


http://codereview.appspot.com/5640045/diff/7001/doc/code.html
File doc/code.html (right):

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode125
doc/code.html:125: Then create a file named
<code>$GOPATHsrc/example/newmath/sqrt.go</code>
s/GOPATHsrc/GOPATH\/src/

http://codereview.appspot.com/5640045/

[adg-iFWiy5xATs8dnm+]

LGTM


http://codereview.appspot.com/5640045/diff/7001/doc/code.html
File doc/code.html (right):

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode10
doc/code.html:10: installing, and fetching Go packages and commands.

Post by r***@golang.org
don't you fetch before you build and install?

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode22
doc/code.html:22: the <code>GOPATH</code> environment variable.

Post by r***@golang.org
this paragraph is correct but stilted. try a rewrite. say it out loud.
also you need to say what GOPATH is: what it means and its syntax.

it's

Post by r***@golang.org
introduced badly.

Rewrote the whole section.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode26
doc/code.html:26: A <code>GOPATH</code> entry contains Go source files,
package objects, and

Post by r***@golang.org
what is a GOPATH entry? i thought it would just be the name of a

directory.

went with "workspace" throughout

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode31
doc/code.html:31: <li>Source files are kept under
<code>$GOPATH/src/<i>importpath</i></code>

Post by r***@golang.org
what is an importpath?

Removed.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode41
doc/code.html:41: in a directory are considered part of the one package.

Post by r***@golang.org
subdirectories form independent packages

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode146
doc/code.html:146: This package is imported by its path name, starting
after the <code>src</code>

Post by r***@golang.org
the path name of the directory it's in

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode158
doc/code.html:158: The <code>go</code> tool takes several commands, the
most central being

Post by r***@golang.org
s/takes/comprises/

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode165
doc/code.html:165: to the <code>pkg</code> or <code>bin</code>
subdirectories of the

Post by r***@golang.org
s/subdirectories/subdirectory/

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode166
doc/code.html:166: <code>GOPATH</code> in which the package source
resides.

Post by r***@golang.org
another meaning of GOPATH

Fixed.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode176
doc/code.html:176: $ go install example/newmath

Post by r***@golang.org
if you're in example/newmath, which you usually are when you're

working on it,

Post by r***@golang.org
you only need
go install

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode180
doc/code.html:180: No output means that the package and all its
dependencies were built correctly.

Post by r***@golang.org
"No output" is a confusing subject for a sentence, and grammatically

ambigous.

Post by r***@golang.org
No people mean to do that.
No people means to do that.

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode232
doc/code.html:232: Then we run <code>go install</code>, which builds and
installs the binary to

Post by r***@golang.org
s/Then/Next,/ ?

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode241
doc/code.html:241: To run the program, invoke it by name like you would

Post by r***@golang.org
the subject of these sentences is sliding around: passive voice, you,

it, we,

Post by r***@golang.org
...
decide who the subject is and stick with it

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode255

Post by r***@golang.org
what's a GOPATH tree?

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode271
doc/code.html:271: When building a command the executable is written the
current directory.

Post by r***@golang.org
tell them what it's called. it's not obvious.

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode280
doc/code.html:280: Go has a lightweight test framework composed of the
<code>go</code> tool and

Post by r***@golang.org
really the go test subcommand

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode294
doc/code.html:294: Let's add a test to our <code>newmath</code> package
by creating the file

Post by r***@golang.org
shifting subjects again

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode331
doc/code.html:331: revision control system (such as Git or Mercurial).
This allows the

Post by r***@golang.org
drop the parens

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode332
doc/code.html:332: <code>go</code> tool to automatically fetch packages
from remote repositories.

Post by r***@golang.org
unsplit the infinitive

Done.

http://codereview.appspot.com/5640045/diff/7001/doc/code.html#newcode352

Post by r***@golang.org
if it's already present but in a later directory, does it replace or

override?

Done.

http://codereview.appspot.com/5640045/

[Andrew Gerrand]

LGTM

Uh, I mean PTAL.

[r***@golang.org]

this is much better


http://codereview.appspot.com/5640045/diff/12001/doc/code.html
File doc/code.html (right):

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode8
doc/code.html:8: This document details the development of a simple Go
package and introduces the
s/details/demonstrates/

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode9
doc/code.html:9: <a href="/cmd/go/">go tool</a>, the standard tool for
fetching, building, and
maybe
the standard way to fetch, ...

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode9
doc/code.html:9: <a href="/cmd/go/">go tool</a>, the standard tool for
fetching, building, and
i'd rather you called this the "go command", since there are also "go
tools".

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode21
doc/code.html:21: configuration files to build Go code. Instead, it uses
the source code to find
or other configuration files to guide program construction.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode23
doc/code.html:23: build scripts are always in sync; they are one and the
same.
nice.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode27
doc/code.html:27: The one thing you must configure is the
<code>GOPATH</code> environment
The one thing you must do is set a GOPATH...

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode29
doc/code.html:29: tools) where to find the Go packages on your system.
s/find/& and install/

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode43
doc/code.html:43: (On a Windows system we use semicolons as the path
separator instead of
s/ we/,/

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode49
doc/code.html:49: <code>/home/user/mygo</code>) specifies the location
of a workspace.
italicise workspace and define it by by deleting the the paragraph
break.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode53
doc/code.html:53: A workspace contains Go source files, package objects,
and command executables.
s/.$/
forming a self-contained set of Go programs.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode64
doc/code.html:64: Subdirectories of the <code>src</code> directory form
independent packages, and
s/form/hold/

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode66
doc/code.html:66: <code>.s</code>) in one of these subdirectories are
considered part of the same
in each subdirectory are elements of that subdirectory's package.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode73
doc/code.html:73: and then &mdash; if the package source isn't found
there &mdash; it searches
no spaces around the dashes.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode78
doc/code.html:78: Multiple workspaces can <code>GOPATH</code> offer some
flexibility and
delete GOPATH - it's nonsense otherwise

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode80
doc/code.html:80: To get started, create a <code>$HOME/mygo</code>
directory and set it as the
start a new paragraph, section maybe

Let's work through a simple example. First, create ...

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode97
doc/code.html:97: libraries.
not sure you want to say this. it's actually not that important and
it'll encourage people to create reallyLongNamesThatAreSureToBeUnique.
maybe refer to effective go instead. hash is a fine package name.
also it might be worth reiterating the difference between packages and
path names, or at least referring to effective go if the concepts are
unclear.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode101
doc/code.html:101: A convenient way to choose a name space is to use the
location of your version
s/A convenient/The best/

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode119
doc/code.html:119: We'll use <code>example/</code> as our name space:
maybe code.google.com?

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode200
doc/code.html:200: The <code>go</code> tool comprises several commands,
the most central being
here use
The go command comprises several subcommands,

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode301
doc/code.html:301: To run the program, invoke it by name like you would
any other command:
s/like/as/

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode400
doc/code.html:400: this property to automatically fetch packages from
remote repositories.
unsplit

http://codereview.appspot.com/5640045/

[adg-iFWiy5xATs8dnm+]

PTAL


http://codereview.appspot.com/5640045/diff/12001/doc/code.html
File doc/code.html (right):

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode8
doc/code.html:8: This document details the development of a simple Go
package and introduces the

Post by r***@golang.org
s/details/demonstrates/

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode9
doc/code.html:9: <a href="/cmd/go/">go tool</a>, the standard tool for
fetching, building, and

Post by r***@golang.org
maybe
the standard way to fetch, ...

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode9
doc/code.html:9: <a href="/cmd/go/">go tool</a>, the standard tool for
fetching, building, and

Post by r***@golang.org
i'd rather you called this the "go command", since there are also "go

tools".

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode21
doc/code.html:21: configuration files to build Go code. Instead, it uses
the source code to find

Post by r***@golang.org
or other configuration files to guide program construction.

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode27
doc/code.html:27: The one thing you must configure is the
<code>GOPATH</code> environment

Post by r***@golang.org
The one thing you must do is set a GOPATH...

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode27
doc/code.html:27: The one thing you must configure is the
<code>GOPATH</code> environment

Post by r***@golang.org
The one thing you must do is set a GOPATH...

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode29
doc/code.html:29: tools) where to find the Go packages on your system.

Post by r***@golang.org
s/find/& and install/

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode43
doc/code.html:43: (On a Windows system we use semicolons as the path
separator instead of

Post by r***@golang.org
s/ we/,/

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode49
doc/code.html:49: <code>/home/user/mygo</code>) specifies the location
of a workspace.

Post by r***@golang.org
italicise workspace and define it by by deleting the the paragraph

break.

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode53
doc/code.html:53: A workspace contains Go source files, package objects,
and command executables.

Post by r***@golang.org
s/.$/
forming a self-contained set of Go programs.

It's not exactly a self-contained set, as packages in one workspace may
depend on packages from another. I know what you mean, though. I went
with:

"A workspace contains Go source files and their associated package
objects, and command executables."

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode64
doc/code.html:64: Subdirectories of the <code>src</code> directory form
independent packages, and

Post by r***@golang.org
s/form/hold/

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode66
doc/code.html:66: <code>.s</code>) in one of these subdirectories are
considered part of the same

Post by r***@golang.org
in each subdirectory are elements of that subdirectory's package.

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode73
doc/code.html:73: and then &mdash; if the package source isn't found
there &mdash; it searches

Post by r***@golang.org
no spaces around the dashes.

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode78
doc/code.html:78: Multiple workspaces can <code>GOPATH</code> offer some
flexibility and

Post by r***@golang.org
delete GOPATH - it's nonsense otherwise

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode80
doc/code.html:80: To get started, create a <code>$HOME/mygo</code>
directory and set it as the

Post by r***@golang.org
start a new paragraph, section maybe
Let's work through a simple example. First, create ...

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode97
doc/code.html:97: libraries.

Post by r***@golang.org
not sure you want to say this. it's actually not that important and

it'll

Post by r***@golang.org
encourage people to create reallyLongNamesThatAreSureToBeUnique. maybe

refer to

Post by r***@golang.org
effective go instead. hash is a fine package name.

hash is a fine package name, but we're already using it, and this
paragraph is about import paths, not package names. I understand your
fear but I think the example we give in the next couple of paragraphs
should steer people in the right direction.

Post by r***@golang.org
also it might be worth reiterating the difference between packages and

path

Post by r***@golang.org
names, or at least referring to effective go if the concepts are

unclear.

Done.

Also added a "Further reading" section to the end of the document.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode101
doc/code.html:101: A convenient way to choose a name space is to use the
location of your version

Post by r***@golang.org
s/A convenient/The best/

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode119

Post by r***@golang.org
maybe code.google.com?

I'd prefer to stick with the shorter name for now, so we can demonstrate
go get later.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode200
doc/code.html:200: The <code>go</code> tool comprises several commands,
the most central being

Post by r***@golang.org
here use
The go command comprises several subcommands,

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode301
doc/code.html:301: To run the program, invoke it by name like you would

Post by r***@golang.org
s/like/as/

Done.

http://codereview.appspot.com/5640045/diff/12001/doc/code.html#newcode400
doc/code.html:400: this property to automatically fetch packages from
remote repositories.

Post by r***@golang.org
unsplit

Done.

http://codereview.appspot.com/5640045/

[r***@golang.org]

getting close


http://codereview.appspot.com/5640045/diff/14002/doc/code.html
File doc/code.html (right):

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode47
doc/code.html:47: Each path in the list (in this case
<code>/home/user/ext</code> and
s/and/or/
number error

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode85
doc/code.html:85: $ mkdir -p $GOPATH/src # create a place to put
source code
maybe also put $GOPATH/bin into $PATH. at least suggest it

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode92
doc/code.html:92: The standard packages are given short import paths
like <code>"fmt"</code> and
s/like/such as/

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode96
doc/code.html:96: libraries.
i still think this is confusing. there are two pieces, package name and
the import path, and the way you introduce them confuses matters because
these are the same for fmt. also, the term 'name space' is undefined.
rewrite so it's clear there are two pieces and that it's only the
import path that has uniqueness issues.

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode126
doc/code.html:126: (Assuming that you still have <code>GOPATH</code> set
from the previous
not a sentence. not even sure what it's about.

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode197
doc/code.html:197: Go's naming conventions.
why all the way down here?

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode233
doc/code.html:233: has the same affect as the one above:
s/:/, assuming GOPATH has only the one entry:

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode316
doc/code.html:316: their full path.
ok, although it's probably better to mention this earlier and make this
a callback

http://codereview.appspot.com/5640045/

[adg-iFWiy5xATs8dnm+]

PTAL


http://codereview.appspot.com/5640045/diff/14002/doc/code.html
File doc/code.html (right):

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode47
doc/code.html:47: Each path in the list (in this case
<code>/home/user/ext</code> and

Post by r***@golang.org
s/and/or/
number error

Done.

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode85
doc/code.html:85: $ mkdir -p $GOPATH/src # create a place to put
source code

Post by r***@golang.org
maybe also put $GOPATH/bin into $PATH. at least suggest it

Done.

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode92
doc/code.html:92: The standard packages are given short import paths
like <code>"fmt"</code> and

Post by r***@golang.org
s/like/such as/

Done.

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode96
doc/code.html:96: libraries.

Post by r***@golang.org
i still think this is confusing. there are two pieces, package name

and the

Post by r***@golang.org
import path, and the way you introduce them confuses matters because

these are

Post by r***@golang.org
the same for fmt. also, the term 'name space' is undefined. rewrite so

it's

Post by r***@golang.org
clear there are two pieces and that it's only the import path that

has

Post by r***@golang.org
uniqueness issues.

I think when read top-to-bottom the effect is that they are introduced
as distinct elements. Maybe I'm wrong. I'll read over it and think about
it some more.

Removed references to "name space", using "base import path" instead.

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode126
doc/code.html:126: (Assuming that you still have <code>GOPATH</code> set
from the previous

Post by r***@golang.org
not a sentence. not even sure what it's about.

Done.

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode197
doc/code.html:197: Go's naming conventions.

Post by r***@golang.org
why all the way down here?

I figure that this is the point where they might still be saying "huh?"
I don't want to send them off to another document before reading this
section.

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode233
This is assumed from the beginning of the document...

http://codereview.appspot.com/5640045/diff/14002/doc/code.html#newcode316
doc/code.html:316: their full path.

Post by r***@golang.org
ok, although it's probably better to mention this earlier and make

this a

Post by r***@golang.org
callback

Done.

http://codereview.appspot.com/5640045/

[r***@golang.org]

LGTM



http://codereview.appspot.com/5640045/diff/19001/doc/code.html
File doc/code.html (right):

http://codereview.appspot.com/5640045/diff/19001/doc/code.html#newcode91
doc/code.html:91: Add the following lines to <code>$HOME/.profile</code>
(or equivalent):
If you want to do this, add...

http://codereview.appspot.com/5640045/

[adg-iFWiy5xATs8dnm+]

*** Submitted as
http://code.google.com/p/go/source/detail?r=fc74ef570a49 ***

doc: expand code.html to discuss the go tool in more depth

R=golang-dev, balasanjay, r
CC=golang-dev
http://codereview.appspot.com/5640045



http://codereview.appspot.com/5640045/diff/19001/doc/code.html
File doc/code.html (right):

http://codereview.appspot.com/5640045/diff/19001/doc/code.html#newcode91
doc/code.html:91: Add the following lines to <code>$HOME/.profile</code>

Post by r***@golang.org
If you want to do this, add...

Done, but without the if. They should do it.

http://codereview.appspot.com/5640045/